feat(primitives): impl From<Genesis> for ChainSpec #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement From<ethers_core::utils::Genesis> for ChainSpec * update docs on forkid and hardfork * set ChainSpec fields as public
* remove Hardfork::all_forks as it's unused
* The merge netsplit block was set by geth here: ethereum/go-ethereum#25372 because of the "block" suffix, the field is pulled to create a forkid in geth's gatherBlocks method
Codecov Report
@@ Coverage Diff @@
## main #921 +/- ##
==========================================
- Coverage 74.04% 73.99% -0.05%
==========================================
Files 288 292 +4
Lines 30783 31719 +936
==========================================
+ Hits 22792 23471 +679
- Misses 7991 8248 +257
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Rjected
added
C-enhancement
gakonst
approved these changes
Jan 18, 2023
Comment on lines
+204
to
+217
| // TODO: eip-158 was also activated when eip-155 was activated, but we don't have the | ||
| // proper hardfork identifier for it. this breaks the hardfork abstraction slightly | ||
| (Hardfork::SpuriousDragon, genesis.config.eip155_block), | ||
| (Hardfork::Byzantium, genesis.config.byzantium_block), | ||
| (Hardfork::Constantinople, genesis.config.constantinople_block), | ||
| (Hardfork::Petersburg, genesis.config.petersburg_block), | ||
| (Hardfork::Istanbul, genesis.config.istanbul_block), | ||
| (Hardfork::Muirglacier, genesis.config.muir_glacier_block), | ||
| (Hardfork::Berlin, genesis.config.berlin_block), | ||
| (Hardfork::London, genesis.config.london_block), | ||
| (Hardfork::ArrowGlacier, genesis.config.arrow_glacier_block), | ||
| (Hardfork::GrayGlacier, genesis.config.gray_glacier_block), | ||
| // TODO: similar problem as eip-158, but with the merge netsplit block. only used in | ||
| // sepolia, but required for proper forkid generation |
There was a problem hiding this comment.
The first TODO:
Using Hardfork::Tangerine works for mainnet because 155/158 were both activated in tangerine, to fix this for an arbitrary genesis we might want to split Hardfork::Tangerine into:
Hardfork::Eip150,
Hardfork::Eip158,The second TODO:
I actually added Hardfork::MergeNetsplit, so we just need to add
(Hardfork::MergeNetsplit, genesis.config.merge_netsplit_block),and delete the TODO
Comment on lines
-75
to
-76
| /// **CAUTION**: This assumes the current hardfork's block number is the current head and uses | ||
| /// all known future hardforks to initialize the filter. |
There was a problem hiding this comment.
The behavior is consistent with the comment, but the caution is probably not warranted because we are explicitly passing in a ChainSpec. Before #747, the signature was:
pub fn fork_filter(&self) -> ForkFilterwhich is not explicit as to what future fork blocks are used to initialize the ForkFilter, hence the caution.
So maybe the comment should be added back, but without the **CAUTION**.
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 5, 2023
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 5, 2023
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
From<ethers_core::utils::Genesis> for ChainSpecand updatesHardfork. The fields onChainSpecare also documented and set aspub.The EIP-2481 test vector in
test_decode_block_headeris updated to check the header's hash.Some questions / things left TODO:
Hardfork::MergeNetsplitBlocktoHardfork. The merge netsplit block is used in sepolia as a fork block, so it is used to calculate a forkid.eip_155_blockandeip_158_blockare both set and are different. Currently we just use the value ofeip_155_block. Situations where EIP155 and EIP158 are both set, but on different fork blocks, seem rare. So maybe the current behavior is ok?Extracted from #623