fmt: add group_imports = StdExternalCrate
#9141
Conversation
@mattsse No worries, let's do it like last time on the clippy. Tell me as soon as you're ready to merge, and I'll update this PR afterwards, leave it open, I'll deal with it :) |
crates/evm/src/execute.rs
Outdated
| pub use reth_execution_errors::{BlockExecutionError, BlockValidationError}; | ||
| use reth_execution_types::ExecutionOutcome; | ||
| use reth_primitives::{BlockNumber, BlockWithSenders, Receipt, Request, U256}; | ||
| use reth_prune_types::PruneModes; | ||
| pub use reth_storage_errors::provider::ProviderError; | ||
| use revm::db::BundleState; | ||
| use revm_primitives::db::Database; |
There was a problem hiding this comment.
as suggested, would have been good if an issue was opened to discuss this before the work was put in to impl this. we don't want this lint because it doesn't make a difference between pub use and private use statements.
if you can revert the mixing of pub use and private use statements, and remove the lint from ci, we can merge this.
There was a problem hiding this comment.
I'm not sure this is possible here:
- From what I see in group_imports,
StdExternalCrategenerates three groups but does not differentiatepub useanduse - The thing you are mentioning here seems to be related to [unstable option]
group_importsrust-lang/rustfmt#5083 (comment) but unfortunately I don't think this is possible right now, wdyt?
There was a problem hiding this comment.
Don't hesitate to close if needed this is not a problem, this was just adding one line to the fmt file and running cargo +nightly fmt that's why I didn't open an issue for this before implementation.
There was a problem hiding this comment.
I don't think so, I tried but as soon as we provide a group_import element in the fmt, it seems that all imports are automatically rearranged at save...
|
closing until |
Related #9041 (comment)