feat: implement block downloader#9118
Merged
mattsse merged 6 commits intomatt/engine2from Jun 27, 2024
Merged
Conversation
fgimenez
requested review from
Rjected,
gakonst,
mattsse and
rkrasiuk
as code owners
mattsse
requested changes
Jun 26, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this is great!
love the tests, left some nits and suggestions
crates/engine/tree/src/download.rs
Outdated
Collaborator
There was a problem hiding this comment.
I'd like this to accept Arc<dyn Consensus> so that we are independent of the consensus and can reuse this for OP
Member
Author
There was a problem hiding this comment.
Arc<ChainSpec> should be valid for OP or am I missing something? I see that FullBlockClient receives a Consensus implementation, but it is already defined as Arc<dyn Consensus>?
Member
Author
There was a problem hiding this comment.
ok, changed here 36730cf to use consensus as constructor arg instead of chainspec, ptal
fgimenez
force-pushed
the
fgimenez/implement-block-downloader
branch
from
97eb334 to
eceb543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #9011
Some changes compared to
reth/crates/consensus/beacon/src/engine/sync.rs
Lines 35 to 39 in 83cbcb9
BlockDownloadertrait and be able to:DownloadOutcomewith more than one downloaded block as a result of pollAlso modified
DownloadRequest::Blocksto wrap aHashSet<B256>instead of aVec<B256>, let me know wdyt.