chore: rename PipelineHandler -> BackfillSync#9059
Merged
mattsse merged 1 commit intomatt/engine2from Jun 24, 2024
Merged
Conversation
github-actions
bot
added
A-consensus
mattsse
approved these changes
Jun 24, 2024
| /// Start the pipeline with the given target. | ||
| pub enum BackfillAction { | ||
| /// Start backfilling with the given target. | ||
| Start(PipelineTarget), |
Collaborator
There was a problem hiding this comment.
makes sense to keep this type as `PipelineTarget so we don't need to change existing code.
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9008
Renamed
PipelineHandler,PipelineEvent,PipelineActionandpipelinemodule to theirBackfillcounterparts.Still keeping
PipelineErrorandPipelineTargetfromreth_stages_apiinBackfillEvent, @mattsse let me know wdyt