feat(primitives): impl genesis state root helper #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
A-utils
* expands GenesisAccount to have the proper fields * implement Encodable and Decodable for GenesisAccount * add helper to calculate the state root from a GenesisAccount hashmap * add tests for simple state roots
Rjected
force-pushed
the
dan/genesis-state-root
branch
from
cca7b79 to
bd927c8
Compare
gakonst
approved these changes
Jan 18, 2023
Comment on lines
+143
to
+152
| let fixtures: Vec<(Address, H256)> = vec![ | ||
| ( | ||
| hex!("9fe4abd71ad081f091bd06dd1c16f7e92927561e").into(), | ||
| hex!("4b35be4231841d212ce2fa43aedbddeadd6eb7d420195664f9f0d55629db8c32").into(), | ||
| ), | ||
| ( | ||
| hex!("c2ba9d87f8be0ade00c60d3656c1188e008fbfa2").into(), | ||
| hex!("e1389256c47d63df8856d7729dec9dc2dae074a7f0cbc49acad1cf7b29f7fe94").into(), | ||
| ), | ||
| ]; |
There was a problem hiding this comment.
how were these chosen? do we know this is the right state root?
There was a problem hiding this comment.
These were chosen by doing the following:
- Generating an address
- Creating a
genesis.jsongiving each addressesU256::max()coins - Initializing and starting geth with this
genesis.json - Retrieving the genesis block over RPC
- Getting the state root from the returned block
So these are not official test cases, and to reproduce these test cases the above procedure would have to be repeated or scripted in a test.
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 5, 2023
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 5, 2023
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a method to calculate the state root, given a
HashMap<Address, GenesisAccount>.GenesisAccountis expanded to include optionalcodeandstoragefields.RLP traits
EncodableandDecodableare implemented forGenesisAccount. This is necessary for state root calculation.The following tests are added for state root calculation:
genesis.jsonwith geth, gathering geth's reported state root over RPC.Conversions from
ethers_core::utils::GenesisAccounttoGenesisAccountare also added.Extracted from #623