chore(rpc): move EthApi trait into own crate#8847
Closed
emhane wants to merge 17 commits intomatt/scaffold-ethapifrom
Closed
chore(rpc): move EthApi trait into own crate#8847emhane wants to merge 17 commits intomatt/scaffold-ethapifrom
EthApi trait into own crate#8847emhane wants to merge 17 commits intomatt/scaffold-ethapifrom
Conversation
emhane
added
C-debt
mattsse
requested changes
Jun 16, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
supportive
I want to keep changes in other crates minimal and I think we can prevent this by doing re-exports from reth-rpc
| use crate::primitives::U256; | ||
| use clap::Args; | ||
| use reth_rpc::eth::gas_oracle::GasPriceOracleConfig; | ||
| use reth_rpc_eth_api::GasPriceOracleConfig; |
Collaborator
There was a problem hiding this comment.
I want to avoid these changes, instead this should be re-exported from reth-rpc
Collaborator
Author
There was a problem hiding this comment.
eth is the only reth-rpc module used in reth-node-core builder, hence why I went with updating the dep here
emhane
force-pushed
the
emhane/move-ethapi
branch
from
27ae884 to
c5f6c5a
Compare
emhane
force-pushed
the
emhane/move-ethapi
branch
from
4c923b0 to
9ecf026
Compare
Collaborator
Author
|
incremental progress committed in #8887 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
EthApitrait, and building-block traits, into own crate. This makes it possible to implEthApiServerfor a generic type that impl the building-block traits.This way, small parts of the
EthApiServerimpl, can be customised, by overriding the default impl of any of the building-block traits.