chore(rpc): impl EthApiServer helper traits on type like EthApi#8799
Merged
emhane merged 100 commits intomatt/scaffold-ethapifrom Jun 13, 2024
Merged
chore(rpc): impl EthApiServer helper traits on type like EthApi#8799emhane merged 100 commits intomatt/scaffold-ethapifrom
EthApiServer helper traits on type like EthApi#8799emhane merged 100 commits intomatt/scaffold-ethapifrom
Conversation
Signed-off-by: jsvisa <delweng@gmail.com>
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Oliver Nordbjerg <hi@notbjerg.me>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com> Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
emhane
force-pushed
the
emhane/optimism-api
branch
from
3c064fb to
f7b076d
Compare
…ype with data layout like EthApi
emhane
changed the title
EthApi helper traits on type like EthApiEthApiServer helper traits on type like EthApi
emhane
force-pushed
the
emhane/optimism-api
branch
from
93c1d96 to
31960d3
Compare
mattsse
approved these changes
Jun 13, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
the helper macros make sense, to quickly implement the sub trait
Comment on lines
+182
to
+185
| #[cfg(feature = "optimism")] | ||
| deposit_nonce: None, | ||
| #[cfg(feature = "optimism")] | ||
| deposit_receipt_version: None, |
Collaborator
There was a problem hiding this comment.
we need to find a way to get rid of these features
Collaborator
Author
There was a problem hiding this comment.
they should be able to remove when optimism feature is entirely removed from the crate, as long as we have some dep for which we pull in optimism feature, likelihood that that crate pulls in reth-primitives with optimism feature, is very high - and we're screwed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadPendingBlock, so it can be reused for any network stack.EthApiServeron types with same data layout asEthApi. This makes it quick to implement customEthApiServerbehaviour for other networks, that are identical in data layout toEthApi, likeOptimismApi.