feat(tree-engine): invalid ancestor handling#8795
Merged
rkrasiuk merged 1 commit intomatt/engine2from Jun 13, 2024
Merged
Conversation
mattsse
approved these changes
Jun 13, 2024
Comment on lines
+28
to
+29
| block: Arc<SealedBlock>, | ||
| senders: Arc<Vec<Address>>, |
Collaborator
There was a problem hiding this comment.
why do we need them separate?
| let tree_state = self.state.tree_state.read(); | ||
| block = tree_state | ||
| .block_by_hash(hash) | ||
| // TODO: clone for compatibility. should we return an Arc here? |
Collaborator
There was a problem hiding this comment.
I think we do,
the caller can then still decide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Invalid ancestor handling.