feat: create init structure of tree state#8757
Merged
rkrasiuk merged 1 commit intomatt/engine2from Jun 13, 2024
Merged
Conversation
rkrasiuk
added
C-enhancement
mattsse
approved these changes
Jun 11, 2024
Rjected
reviewed
Jun 12, 2024
Comment on lines
+21
to
+27
| /// Represents an executed block stored in-memory. | ||
| #[derive(Clone, Debug)] | ||
| struct ExecutedBlock { | ||
| block: Arc<SealedBlockWithSenders>, | ||
| state: Arc<()>, | ||
| trie: Arc<()>, | ||
| } |
Member
There was a problem hiding this comment.
any reason why the struct is not just Arc'ed in data structures that use it, since all the fields are Arc?
Member
Author
There was a problem hiding this comment.
we will need to clone different states for different purposes. e.g. sealed block should be returned for block_by_hash request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create initial internal structure of tree state.