refactor: rename BundleStateWithReceipts to BlockExecutionOutcome

[tcoratger]

This PR:

• Renames BundleStateWithReceipts to BlockExecutionOutcome
• Adds with_receipts and with_requests

Should close #8727.

[mattsse]

hmm, this is slightly more nuanced because a ton of variables still refer to this as state and other types also refer to this as state.

I very much prefer this new name because it's accurate.

but this clashes with how we refer to it, referring to this as state is even more confusing...

not sure how to proceed...

[mattsse]

hmm, while naming is an improvement, this does not fit if we keep using it like this.

[tcoratger]

Yes I thought we were saving it for another PR as there were a lot of changes to make but it's true that it doesn't make much sense to merge like that.

So I tried changing the names around BlockExecutionOutcome for overall consistency, hope I didn't forget any.

Let me know what you think about this

[mattsse]

I like this a lot more than Bundlestate,

after looking at this, I would even consider dropping the Block prefix and just do ExecutionOutput this way it's not tied to Block because it could this can represent multiple blocks.

but I'd like more feedback here @Rjected @gakonst @shekhirin @rkrasiuk @rakita

[tcoratger]

I like this a lot more than Bundlestate,

after looking at this, I would even consider dropping the Block prefix and just do ExecutionOutput this way it's not tied to Block because it could this can represent multiple blocks.

but I'd like more feedback here @Rjected @gakonst @shekhirin @rkrasiuk @rakita

@mattsse

• On the one hand it will greatly alleviate the writing of the naming so it's not bad.
• But on the other hand ExecutionResult seems very generic and it may lack information about the interior of the object, right?

[shekhirin]

I like ExecutionOutput, it also makes names shorter everywhere, which is especially good for types like FullBlockExecutionDataProvider

[gakonst]

ExecutionOutput 👍

[mattsse]

ExecutionOutput it is then

[mattsse]

actually, can we roll this back to Outcome 1bd67d3, I like this more than output.
sorry about this

[mattsse]

ty 🫡