Skip to content

chore(rpc): EthBlocks default impl#8723

Merged
emhane merged 67 commits intomatt/scaffold-ethapifrom
emhane/ethapi-blocks
Jun 11, 2024
Merged

chore(rpc): EthBlocks default impl#8723
emhane merged 67 commits intomatt/scaffold-ethapifrom
emhane/ethapi-blocks

Conversation

@emhane
Copy link
Collaborator

@emhane emhane commented Jun 10, 2024

  • Moves blocks eth_ RPC methods to default trait methods of EthBlocks, reusable for any network
  • Moves remaining transaction RPC methods using LoadBlock, into EthTransactions default impl
  • Rounds of creation of traits to read data from db, prefixed Load, by updating docs

@emhane emhane added the S-blocked This cannot more forward until something else changes label Jun 10, 2024
@emhane emhane changed the base branch from main to emhane/ethapi-call June 10, 2024 14:24
@emhane emhane requested a review from onbjerg as a code owner June 10, 2024 14:24
Base automatically changed from emhane/ethapi-call to matt/scaffold-ethapi June 11, 2024 16:25
@emhane emhane merged commit 197b182 into matt/scaffold-ethapi Jun 11, 2024
@emhane emhane deleted the emhane/ethapi-blocks branch June 11, 2024 18:07
@emhane emhane mentioned this pull request Jun 12, 2024
emhane added a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code S-blocked This cannot more forward until something else changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments