feat: support no_std for reth-storage-errors#8702
Closed
JackG-eth wants to merge 8 commits intoparadigmxyz:mainfrom
Closed
feat: support no_std for reth-storage-errors#8702JackG-eth wants to merge 8 commits intoparadigmxyz:mainfrom
no_std for reth-storage-errors#8702JackG-eth wants to merge 8 commits intoparadigmxyz:mainfrom
Conversation
JackG-eth
changed the title
Contributor
Author
|
Couple more things to clean up. |
mattsse
requested changes
Jun 9, 2024
mattsse
requested changes
Jun 9, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
we don't have proper no-std tests in ci yet, so this currently passes, but fails with cargo c --no-default-features, mainly std related imports
Contributor
Author
added necessary imports where needed, also added a couple more feature std flags where std libs are used. |
JackG-eth
force-pushed
the
feature_no_std_suppport
branch
from
c0e0178 to
5671ee3
Compare
mattsse
approved these changes
Jun 10, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
@DaniPopes I believe no-std-thiserror has a few limitations.
rolling this back once Error is available in no_std isn't a big deal so I'm fine with this, even if only temporary
wdyt?
DaniPopes
changed the title
no_std for reth-storage-errors
DaniPopes
changed the title
no_std for reth-storage-errorsno_std for reth-storage-errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
have a subset of crates with no_std supports (evm specifically)
we need to do some prep for this first by making some crates no_std first
Motivation
closes #8459