chore(rpc): reusable eth api EthCall#8683
Merged
emhane merged 67 commits intomatt/scaffold-ethapifrom Jun 11, 2024
Merged
Conversation
emhane
requested review from
DaniPopes,
fgimenez,
rakita and
shekhirin
as code owners
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
mattsse
requested changes
Jun 10, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this is coming together.
having a ton of traits can be overwhelming at first, but this makes a ton of sense here because the eth_api is massive, and dividing this in multiple traits makes sense, because this allows the consumer to reuse as much as possible from the ethapiinner and only reimplement necessary functions, right?
mattsse
approved these changes
Jun 10, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
looks like a ton of changes are actually due to main rebase?
let's get this into the branch and then have a closer look.
I believe this is looking great and will be very useful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EthApi, to default trait implEthCallEthApi, to default trait implEthFees