chore(rpc): pending block helper trait#8640
Merged
emhane merged 44 commits intomatt/scaffold-ethapifrom Jun 8, 2024
Merged
Conversation
emhane
changed the title
emhane
changed the title
Collaborator
Author
|
blocked by #8639 |
mattsse
reviewed
Jun 6, 2024
mattsse
approved these changes
Jun 7, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
thanks for clarifying,
lgtm
crates/rpc/rpc/src/eth/api/block.rs
Outdated
| @@ -18,6 +18,8 @@ use reth_transaction_pool::TransactionPool; | |||
|
|
|||
| use crate::eth::api::EthBlocks; | |||
|
|
|||
| @@ -15,8 +15,11 @@ use reth_rpc_types::FeeHistory; | |||
| use reth_transaction_pool::TransactionPool; | |||
| use tracing::debug; | |||
|
|
|||
emhane
requested review from
fgimenez,
gakonst,
joshieDo,
rakita and
rkrasiuk
as code owners
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
EthApimethods for loading pending block to default trait methods of new traitLoadPendingBlock. Needed to impl default trait methods forEthBlocksandEthTransactions.