chore(rpc): trait for blocking task#8538
Merged
emhane merged 25 commits intomatt/scaffold-ethapifrom Jun 5, 2024
Merged
Conversation
Collaborator
Author
|
I don't get why this test doesn't work besides, it works locally :'( |
mattsse
requested changes
Jun 3, 2024
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
this change is problematic because it no longer treats CPU-bound and IO-bound tasks differently and spawns them in the pool of blocking tasks, which is a rayon wrapper intended only for tracing tasks that are predominantly CPU-bound
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the interface for executing blocking code in
EthApi.Removes semantically counterintuitive function for running a future on a blocking taskMovesEthApi::on_blocking_taskinto trait methodSpawnBlocking::spawn_blocking_io, which replaces less generalEthTransactions::spawn_blocking. MovesEthApi::spawn_tracing_task_withintoSpawnBlocking::spawn_tracing, replacing less generalEthTransactions::spawn_blocking.EthBlocksandEthTransactionsEthApi::on_blocking_taskwith calls toeth::api::SpawnBlocking::spawn_blocking_ioin impl ofEthApiServer. Moves closer to goal of eventually having default trait method impls forEthApiServer.