chore: extract init to reth-db-common #8171#8186
Closed
willco-1 wants to merge 2 commits intoparadigmxyz:mainfrom
Closed
chore: extract init to reth-db-common #8171#8186willco-1 wants to merge 2 commits intoparadigmxyz:mainfrom
willco-1 wants to merge 2 commits intoparadigmxyz:mainfrom
Conversation
willco-1
requested review from
Rjected,
gakonst,
joshieDo,
mattsse,
onbjerg,
rakita and
shekhirin
as code owners
willco-1
changed the title
emhane
reviewed
May 10, 2024
Collaborator
emhane
left a comment
emhane
left a comment
There was a problem hiding this comment.
I can't see the issue unfortunately, think it requires specific credentials
mattsse
requested changes
May 12, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this is great.
only stylistic nits
mattsse
added
C-debt
Collaborator
|
need any help here with merge conflicts @willco-1 ? |
Collaborator
|
my bad, closing in favour of #8373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracts init to reth-db-common. Let me know if there is any review notes!
closes #8171