feat: write pruning config if --full is present#7938
Merged
mattsse merged 4 commits intoparadigmxyz:mainfrom May 2, 2024
Merged
feat: write pruning config if --full is present#7938mattsse merged 4 commits intoparadigmxyz:mainfrom
mattsse merged 4 commits intoparadigmxyz:mainfrom
Conversation
mattsse
requested changes
Apr 28, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I believe this should do it
can we add a simple test case for this using the LaunchContext struct
similar test setup as these
mattsse
added
C-enhancement
Contributor
Author
|
Changed code structure from previous commit.
|
Rjected
approved these changes
Apr 29, 2024
Member
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
this makes sense to me, iirc we want to replace confy eventually but this works for now
Rjected
changed the title
Rjected
changed the title
Rjected
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7923