feat(primitives): add H128 #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uses patch for now
yutianwu
pushed a commit
to yutianwu/reth
that referenced
this pull request
Jul 30, 2024
* fix: read sidecars from table in `get_take_block_range` * fix lint issue
PeaStew
added a commit
to NeuraProtocol/reth-new-consensus
that referenced
this pull request
Jul 7, 2025
…ot in canonical state - Blocks are successfully created and persisted to database (up to block paradigmxyz#79 in logs) - eth_blockNumber RPC returns 0x0 because it reads from canonical_in_memory_state - Root cause: Our custom consensus bypasses Reth's engine API flow - Blocks are written to DB but not to the canonical in-memory state - BlockchainProvider uses canonical_in_memory_state, not direct DB reads - Proper fix requires integrating with engine API or canonical state notifications - Updated CLAUDE.md to document this critical issue 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET - depends on ethers-rs#1786, currently patched to get it to compile.PR is merged so this is ready.