Conversation
DaniPopes
reviewed
Feb 2, 2024
mattsse
requested changes
Feb 3, 2024
crates/primitives/src/proofs.rs
Outdated
Collaborator
There was a problem hiding this comment.
are we doing this again 😭😭😭😭😭😭😭😭😭😭😭
Collaborator
Author
There was a problem hiding this comment.
bro i legit don't know why it does this. will fmt on linux before merging
onbjerg
force-pushed
the
onbjerg/rm-callrequest
branch
from
e36abdc to
105a3f5
Compare
Collaborator
Author
|
This can either be blocked by alloy-rs/alloy#183 or we can merge and remove the inlining after |
3 tasks
onbjerg
force-pushed
the
onbjerg/rm-callrequest
branch
from
a1fec8a to
0d8c3e6
Compare
mattsse
approved these changes
Feb 9, 2024
| pub nonce: U64, | ||
| /// The gas price for the transaction | ||
| pub gas_price: U128, | ||
| pub gas_price: U256, |
Collaborator
There was a problem hiding this comment.
these are reasonable, should really be u256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on alloy-rs/alloy#178