feat: add SnapshotCursor wrapper and impl HeaderProvider #5170
Merged
feat: add SnapshotCursor wrapper and impl HeaderProvider #5170
SnapshotCursor wrapper and impl HeaderProvider #5170Conversation
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
joshieDo
added
C-enhancement
shekhirin
reviewed
Oct 27, 2023
shekhirin
approved these changes
Oct 27, 2023
mattsse
pushed a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR into #5162
SnapshotCursorwrapperNippyJarCursorfor better UX for decompressing/decoding values.SELECTORandCOLUMNSconst generics from the nippy jar cursor and this one. It's making things hard to read for lil gain imo. So readability will greatly improve in the follow-up PR by removing them.HeaderProvideronSnapshotJarProvider