Skip to content

feat(rpc): move trace_block_with and trace_block_until to EthTransactions#5021

Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom
tcoratger:EthTransactions
Oct 14, 2023
Merged

feat(rpc): move trace_block_with and trace_block_until to EthTransactions#5021
mattsse merged 1 commit intoparadigmxyz:mainfrom
tcoratger:EthTransactions

Conversation

@tcoratger
Copy link
Copy Markdown
Contributor

Should close #5002.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2023

Codecov Report

Merging #5021 (b97dd3f) into main (411893e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 52.38%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc/src/trace.rs 41.97% <47.61%> (-1.71%) ⬇️
crates/rpc/rpc/src/eth/api/transactions.rs 33.49% <53.57%> (+3.05%) ⬆️

... and 4 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.84% <52.38%> (-0.01%) ⬇️
unit-tests 62.29% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.37% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 47.92% <ø> (ø)
networking 76.46% <ø> (+0.02%) ⬆️
rpc 57.91% <52.38%> (+<0.01%) ⬆️
consensus 63.01% <ø> (ø)
revm 27.89% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.02% <ø> (ø)

Copy link
Copy Markdown
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Oct 14, 2023
@mattsse mattsse added C-debt A clean up/refactor of existing code A-rpc Related to the RPC implementation labels Oct 14, 2023
Merged via the queue into paradigmxyz:main with commit 3bf2c88 Oct 14, 2023
mattsse pushed a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move trace_block_with and trace_block_until to EthTransactions trait

2 participants