Skip to content

chore: use new type for BlockchainId#5012

Merged
mattsse merged 1 commit intomainfrom
matt/use-id-type-for-blockchain-id
Oct 13, 2023
Merged

chore: use new type for BlockchainId#5012
mattsse merged 1 commit intomainfrom
matt/use-id-type-for-blockchain-id

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 13, 2023

this replaces the BlockchainId type alias with a wrapper type, this makes it a bit nicer imo.
and also ensures that it no other u64 value can be used as an id to modify chains

@mattsse mattsse added the A-engine Related to the engine implementation label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #5012 (d05ac27) into main (34bc498) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 90.00%.

Impacted file tree graph

Files Coverage Δ
crates/blockchain-tree/src/block_indices.rs 84.45% <ø> (ø)
crates/blockchain-tree/src/blockchain_tree.rs 84.27% <100.00%> (+0.11%) ⬆️
crates/blockchain-tree/src/chain.rs 77.20% <ø> (ø)
crates/blockchain-tree/src/state.rs 83.60% <76.92%> (-2.40%) ⬇️

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.85% <0.00%> (-0.01%) ⬇️
unit-tests 62.38% <90.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.93% <ø> (ø)
blockchain tree 80.82% <90.00%> (+0.01%) ⬆️
pipeline 88.37% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 48.60% <ø> (+0.45%) ⬆️
networking 76.45% <ø> (-0.02%) ⬇️
rpc 57.99% <ø> (+<0.01%) ⬆️
consensus 63.01% <ø> (ø)
revm 27.89% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.24% <ø> (+<0.01%) ⬆️

@mattsse mattsse added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 15fe5ed Oct 13, 2023
@mattsse mattsse deleted the matt/use-id-type-for-blockchain-id branch October 13, 2023 15:09
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-engine Related to the engine implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants