EIP4844 variant to TypedTransactionRequest #5005
Conversation
DoTheBestToGetTheBest
requested review from
Rjected and
mattsse
as code owners
DoTheBestToGetTheBest
changed the title
Codecov Report
... and 60 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rkrasiuk
added
C-enhancement
| pub input: Bytes, | ||
| pub access_list: AccessList, | ||
| pub max_fee_per_blob_gas: u128, | ||
| pub blob_versioned_hashes: Vec<FixedBytes<32>>, |
There was a problem hiding this comment.
we also need a sidecar type that contains the proofs,commitments etc
There was a problem hiding this comment.
This is a problem because BlobTransactionSidecar struct does not implement Encodable and Decodable trait, are you okay if i add them ? This will result another modification for other struct too
There was a problem hiding this comment.
we need to duplicate that struct inside rpc-types and can't reuse the existing one
There was a problem hiding this comment.
we need to duplicate that struct inside rpc-types and can't reuse the existing one
Amazing! I've just done that. Thank you so much !
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
3 participants
close #5004