Conversation
mattsse
added
C-debt
mattsse
force-pushed
the
matt/add-tree-state
branch
from
8605d5a to
7b45714
Compare
Codecov Report
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this kicks off some improvements of the tree impl.
Ideally we want to get rid of the
Arc<Lock<Tree>>and instead only lock when necessary.this is only possible if we can isolate mutable access, this will eventually happen inside the TreeState.
To keep changes smol, this PR merely moves the mutable fields inside the new container type while keeping everything in place.
It will require a few more followups to push more logic inside the state