Skip to content

chore: ask for node type in bug.yml issue template#4988

Merged
shekhirin merged 2 commits intomainfrom
alexey/bug-template-node-type
Oct 12, 2023
Merged

chore: ask for node type in bug.yml issue template#4988
shekhirin merged 2 commits intomainfrom
alexey/bug-template-node-type

Conversation

@shekhirin
Copy link
Member

No description provided.

@shekhirin shekhirin added the A-meta Changes in the contributor workflow and planning label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #4988 (1eb6d1d) into main (65cc314) will increase coverage by 0.07%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 22 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.41% <ø> (+0.01%) ⬆️
unit-tests 62.55% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.62% <ø> (ø)
blockchain tree 80.64% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.52% <ø> (+0.03%) ⬆️
txpool 48.76% <ø> (+0.23%) ⬆️
networking 76.07% <ø> (ø)
rpc 57.96% <ø> (-0.03%) ⬇️
consensus 63.01% <ø> (ø)
revm 27.79% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.33% <ø> (-0.04%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the comment on asking for custom config

options:
- Archive (default)
- Full via --full flag
- Pruned with custom reth.toml config
Copy link
Member

@Rjected Rjected Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should ask for the full config, if custom pruned

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that can be added in additional context

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin enabled auto-merge October 12, 2023 11:45
@shekhirin shekhirin added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 3ab8aec Oct 12, 2023
@shekhirin shekhirin deleted the alexey/bug-template-node-type branch October 12, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Changes in the contributor workflow and planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants