Skip to content

chore: simplify HashedCursorFactory trait#4984

Merged
rkrasiuk merged 2 commits intoparadigmxyz:mainfrom
robinsdan:simp
Oct 12, 2023
Merged

chore: simplify HashedCursorFactory trait#4984
rkrasiuk merged 2 commits intoparadigmxyz:mainfrom
robinsdan:simp

Conversation

@robinsdan
Copy link
Contributor

lifetime param in trait is much harder to understand, and also cause all use place to add that lifetime param.

@rkrasiuk rkrasiuk added C-debt A clean up/refactor of existing code A-trie Related to Merkle Patricia Trie implementation labels Oct 11, 2023
@rkrasiuk
Copy link
Contributor

@robinsdan some checks are failing

@robinsdan robinsdan requested a review from onbjerg as a code owner October 11, 2023 14:50
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #4984 (07745a5) into main (537ad17) will decrease coverage by 0.09%.
Report is 22 commits behind head on main.
The diff coverage is 90.90%.

Impacted file tree graph

Files Coverage Δ
...der/src/bundle_state/bundle_state_with_receipts.rs 92.44% <100.00%> (ø)
crates/trie/src/hashed_cursor/default.rs 100.00% <100.00%> (ø)
crates/trie/src/hashed_cursor/post_state.rs 96.57% <100.00%> (-0.15%) ⬇️
crates/trie/src/proof.rs 96.75% <100.00%> (ø)
bin/reth/src/debug_cmd/in_memory_merkle.rs 1.29% <0.00%> (ø)
crates/trie/src/trie.rs 96.50% <77.77%> (ø)

... and 49 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.41% <0.00%> (+0.07%) ⬆️
unit-tests 62.48% <90.90%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.62% <0.00%> (-0.14%) ⬇️
blockchain tree 80.64% <ø> (+0.01%) ⬆️
pipeline 88.45% <ø> (ø)
storage (db) 74.40% <100.00%> (-0.01%) ⬇️
trie 94.48% <93.54%> (-0.04%) ⬇️
txpool 48.52% <ø> (-0.47%) ⬇️
networking 76.09% <ø> (-0.04%) ⬇️
rpc 57.95% <ø> (-0.62%) ⬇️
consensus 63.01% <ø> (ø)
revm 27.79% <ø> (-0.61%) ⬇️
payload builder 7.96% <ø> (ø)
primitives 86.37% <ø> (+0.91%) ⬆️

Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk added this pull request to the merge queue Oct 12, 2023
Merged via the queue into paradigmxyz:main with commit 3a8c062 Oct 12, 2023
@robinsdan robinsdan deleted the simp branch October 16, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-trie Related to Merkle Patricia Trie implementation C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants