Skip to content

Comments

chore(deps): change revm to use evalir/revm instead of dani branch#4855

Merged
DaniPopes merged 3 commits intoparadigmxyz:mainfrom
Evalir:evalir/change-revm-branch
Sep 29, 2023
Merged

chore(deps): change revm to use evalir/revm instead of dani branch#4855
DaniPopes merged 3 commits intoparadigmxyz:mainfrom
Evalir:evalir/change-revm-branch

Conversation

@Evalir
Copy link
Collaborator

@Evalir Evalir commented Sep 29, 2023

Evalir/revm#4 was merged—so we can switch to using the main PR branch for revm alloy and this should avoid getting build errors.

@Evalir Evalir requested a review from gakonst as a code owner September 29, 2023 13:10
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #4855 (ec98079) into main (23d2baf) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

see 4 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.52% <ø> (-0.01%) ⬇️
unit-tests 62.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.30% <ø> (ø)
blockchain tree 80.44% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.31% <ø> (ø)
trie 94.44% <ø> (ø)
txpool 49.49% <ø> (ø)
networking 76.45% <ø> (-0.05%) ⬇️
rpc 57.78% <ø> (-0.01%) ⬇️
consensus 61.06% <ø> (ø)
revm 28.54% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.29% <ø> (ø)

@DaniPopes
Copy link
Member

Can you update lockfile too

@DaniPopes
Copy link
Member

And deny.toml 😄

@mattsse
Copy link
Collaborator

mattsse commented Sep 29, 2023

also git allow list needs to be updated to make deny job pass

@DaniPopes DaniPopes enabled auto-merge September 29, 2023 13:32
@DaniPopes DaniPopes added this pull request to the merge queue Sep 29, 2023
Merged via the queue into paradigmxyz:main with commit 8f6a33b Sep 29, 2023
@Evalir Evalir deleted the evalir/change-revm-branch branch September 29, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants