Skip to content

refactor: use revm blob fee calc#4637

Merged
Rjected merged 3 commits intomainfrom
matt/use-revm-consts
Sep 18, 2023
Merged

refactor: use revm blob fee calc#4637
Rjected merged 3 commits intomainfrom
matt/use-revm-consts

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 18, 2023

Closes #4444

replaces our own fake exponential and blob fee clac impl with revm native

@mattsse mattsse added the C-debt A clean up/refactor of existing code label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4637 (d09dced) into main (93ccf41) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/payload/builder/src/payload.rs 0.00% <0.00%> (ø)
crates/primitives/src/constants/eip4844.rs 93.33% <ø> (+7.87%) ⬆️
crates/primitives/src/eip4844.rs 0.00% <ø> (ø)
crates/primitives/src/header.rs 94.88% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/transactions.rs 30.76% <0.00%> (ø)
crates/transaction-pool/src/maintain.rs 2.89% <0.00%> (+0.01%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.01% <0.00%> (-0.01%) ⬇️
unit-tests 63.22% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 31.95% <ø> (ø)
blockchain tree 83.59% <ø> (ø)
pipeline 88.54% <ø> (ø)
storage (db) 73.47% <ø> (ø)
trie 94.73% <ø> (+0.03%) ⬆️
txpool 49.91% <0.00%> (+0.48%) ⬆️
networking 77.21% <ø> (-0.08%) ⬇️
rpc 57.41% <0.00%> (-0.01%) ⬇️
consensus 62.42% <ø> (ø)
revm 19.66% <ø> (ø)
payload builder 9.06% <0.00%> (ø)
primitives 86.45% <0.00%> (+0.02%) ⬆️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected Rjected added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 20455d0 Sep 18, 2023
@Rjected Rjected deleted the matt/use-revm-consts branch September 18, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reuse revm eip-4844 impls and constants

2 participants