fix(txpool): pending subpool basefee update#4610
Merged
Conversation
rkrasiuk
added
C-bug
mattsse
requested changes
Sep 15, 2023
rkrasiuk
force-pushed
the
rkrasiuk/fix-pending-subpool-basefee-update
branch
2 times, most recently
from
9370a0e to
3070019
Compare
Codecov Report
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rkrasiuk
force-pushed
the
rkrasiuk/fix-pending-subpool-basefee-update
branch
from
3070019 to
2c95a48
Compare
mattsse
approved these changes
Sep 15, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm,
I'll add a few tests for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4609.
Description
Clear ordered lists first before the transactions are re-inserted with new priority.