Skip to content

feat: add blob transactions subpool#4608

Merged
mattsse merged 1 commit intomainfrom
matt/blob-txs-container
Sep 15, 2023
Merged

feat: add blob transactions subpool#4608
mattsse merged 1 commit intomainfrom
matt/blob-txs-container

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 15, 2023

ref #4445

initial blob tx subpool, doesn't do anything yet, just to keep changes smol.

with blob txs, there's another parameter that determines whether a tx is pending or not (blob fee), also we need to be able to update and rank them independently.

blob txs are more or less separate transactions and don't mix with normal txs (mutually exclusive over account nonce range)

therefor they should be tracked in a separate set.

@mattsse mattsse added C-enhancement New feature or request A-tx-pool Related to the transaction mempool labels Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #4608 (a604d9e) into main (455af56) will decrease coverage by 0.05%.
The diff coverage is 13.04%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/pool/mod.rs 51.52% <ø> (ø)
crates/transaction-pool/src/pool/parked.rs 80.00% <ø> (ø)
crates/transaction-pool/src/pool/pending.rs 83.26% <ø> (ø)
crates/transaction-pool/src/pool/blob.rs 11.76% <11.76%> (ø)
crates/transaction-pool/src/pool/txpool.rs 71.86% <100.00%> (+0.02%) ⬆️

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.62% <13.04%> (-0.02%) ⬇️
unit-tests 63.99% <13.04%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.53% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (+0.03%) ⬆️
txpool 49.24% <13.04%> (-0.52%) ⬇️
networking 77.25% <ø> (ø)
rpc 57.36% <ø> (+<0.01%) ⬆️
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.12% <ø> (ø)
primitives 86.51% <ø> (-0.04%) ⬇️

@mattsse mattsse requested review from Rjected and rkrasiuk September 15, 2023 11:01
@mattsse mattsse added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit b156cb9 Sep 15, 2023
@mattsse mattsse deleted the matt/blob-txs-container branch September 15, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tx-pool Related to the transaction mempool C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants