fix: return UnsupportedFork on V2 endpoints#4593
Merged
Conversation
Rjected
added
C-bug
Member
Author
|
whoops, this breaks some other tests - need to fix |
Codecov Report
... and 14 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Sep 14, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm, like the spec docs
rkrasiuk
approved these changes
Sep 15, 2023
mattsse
approved these changes
Sep 15, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm, needs rebase to fix clippy
Rjected
force-pushed
the
dan/return-unsupported-fork-on-v2-endpoints
branch
from
8515c42 to
d0a0417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the hive
ForkchoiceUpdatedV2 To Request Cancun Payload, Nil Beacon Root (Cancun)andGetPayloadV2 To Request Cancun Payloadtests.This implements the modification to the V2 methods, to return
UnsupportedForkfor post-cancun blocks.