Skip to content

chore(ci): run check and clippy on tests and benches too#4587

Merged
shekhirin merged 10 commits intomainfrom
alexey/cargo-check
Sep 14, 2023
Merged

chore(ci): run check and clippy on tests and benches too#4587
shekhirin merged 10 commits intomainfrom
alexey/cargo-check

Conversation

@shekhirin
Copy link
Member

No description provided.

@shekhirin shekhirin changed the title chore(ci): cargo check on tests and benches chore(ci): run check/fmt/clippy on tests and benches too Sep 13, 2023
@shekhirin shekhirin changed the title chore(ci): run check/fmt/clippy on tests and benches too chore(ci): run check and clippy on tests and benches too Sep 13, 2023
@shekhirin shekhirin marked this pull request as ready for review September 13, 2023 18:31
@shekhirin shekhirin requested a review from mattsse September 13, 2023 18:31
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #4587 (a1c8750) into main (723036b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/trie/src/trie.rs 96.68% <ø> (ø)
crates/prune/src/pruner.rs 82.87% <100.00%> (+0.03%) ⬆️
crates/rpc/rpc-engine-api/src/engine_api.rs 79.23% <100.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.62% <0.00%> (-0.01%) ⬇️
unit-tests 64.03% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.53% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 49.26% <ø> (-0.50%) ⬇️
networking 77.27% <ø> (+0.03%) ⬆️
rpc 57.35% <100.00%> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.12% <ø> (ø)
primitives 86.53% <ø> (-0.01%) ⬇️

@shekhirin shekhirin added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit a8e0880 Sep 14, 2023
@shekhirin shekhirin deleted the alexey/cargo-check branch September 14, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants