Skip to content

chore: demote session established log level #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 2 commits into from
Sep 18, 2023
Merged

chore: demote session established log level #4564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8215a66
chore: demote session established log level
rkrasiuk Sep 12, 2023
43e49dd
add enode to log
mattsse Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/net/network/src/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ use std::{
};
use tokio::sync::mpsc::{self, error::TrySendError};
use tokio_stream::wrappers::UnboundedReceiverStream;
use tracing::{debug, error, info, trace, warn};
use tracing::{debug, error, trace, warn};

/// Manages the _entire_ state of the network.
///
Expand Down Expand Up @@ -676,15 +676,16 @@ where
let total_active =
this.num_active_peers.fetch_add(1, Ordering::Relaxed) + 1;
this.metrics.connected_peers.set(total_active as f64);
info!(
target : "net",
debug!(
target: "net",
?remote_addr,
%client_version,
?peer_id,
?total_active,
kind=%direction,
peer_enode=%NodeRecord::new(remote_addr, peer_id),
"Session established"
);
debug!(target: "net", kind=%direction, peer_enode=%NodeRecord::new(remote_addr, peer_id), "Established peer enode");
Comment on lines 688 to -687
Copy link
Member

@Rjected Rjected Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts on adding the enode back? it was useful when investigating suspicious peers


if direction.is_incoming() {
this.swarm
Expand Down