Merged
Conversation
rkrasiuk
added
A-execution
rkrasiuk
requested review from
Rjected,
gakonst,
joshieDo,
mattsse,
onbjerg,
rakita and
shekhirin
as code owners
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
added
the
S-blocked
rkrasiuk
removed
the
S-blocked
shekhirin
approved these changes
Aug 30, 2023
Member
shekhirin
left a comment
shekhirin
left a comment
There was a problem hiding this comment.
LGTM modulo merge_transactions enum instead of bool
Comment on lines
+305
to
+309
| let with_reverts = self.tip.map_or(true, |tip| { | ||
| !self.prune_modes.should_prune_account_history(block.number, tip) && | ||
| !self.prune_modes.should_prune_storage_history(block.number, tip) | ||
| }); | ||
| self.db().merge_transitions(with_reverts); |
Member
There was a problem hiding this comment.
makes sense. We collect reverts either if tip is not set, or if pruning tells us to not prune the block we're processing.
Contributor
Author
There was a problem hiding this comment.
yup, later on we can address the granularity of the revert retention in the bundle state
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrate pruning into new REVM state.