Skip to content

chore: collect full discarded tx#4353

Merged
mattsse merged 1 commit intomainfrom
matt/use-full-txs-for-discard
Aug 24, 2023
Merged

chore: collect full discarded tx#4353
mattsse merged 1 commit intomainfrom
matt/use-full-txs-for-discard

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 24, 2023

this is prep for deciding when we need to remove a discarded tx from the blob store

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #4353 (c62e5be) into main (0beaf85) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/pool/mod.rs 46.05% <33.33%> (ø)
crates/transaction-pool/src/pool/txpool.rs 72.33% <100.00%> (-0.06%) ⬇️

... and 21 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.70% <16.66%> (-0.02%) ⬇️
unit-tests 63.65% <66.66%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.01% <ø> (ø)
blockchain tree 81.82% <ø> (-0.75%) ⬇️
pipeline 90.07% <ø> (ø)
storage (db) 74.67% <ø> (-0.06%) ⬇️
trie 94.88% <ø> (ø)
txpool 48.14% <66.66%> (-0.05%) ⬇️
networking 77.49% <ø> (-0.02%) ⬇️
rpc 57.97% <ø> (-0.02%) ⬇️
consensus 63.09% <ø> (-0.44%) ⬇️
revm 31.89% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.22% <ø> (-0.12%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit aad1895 Aug 24, 2023
@mattsse mattsse deleted the matt/use-full-txs-for-discard branch August 24, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tx-pool Related to the transaction mempool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants