Skip to content

chore: add TxEip4844::validate_blob#4345

Merged
mattsse merged 1 commit intomainfrom
matt/move-validate-toeip4844
Aug 24, 2023
Merged

chore: add TxEip4844::validate_blob#4345
mattsse merged 1 commit intomainfrom
matt/move-validate-toeip4844

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 24, 2023

adds a new function to validate the sidercar for a TxEip4844 transaction

moves the impl from BlobTransaction

@mattsse mattsse requested a review from gakonst as a code owner August 24, 2023 13:11
@mattsse mattsse requested a review from Rjected August 24, 2023 13:11
@mattsse mattsse added C-enhancement New feature or request M-eip This change relates to the implementation of an EIP labels Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #4345 (3df8cf7) into main (b473f20) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/transaction/eip4844.rs 37.24% <0.00%> (-0.64%) ⬇️

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <0.00%> (-0.01%) ⬇️
unit-tests 63.87% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.03% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.71% <ø> (ø)
trie 94.88% <ø> (+0.03%) ⬆️
txpool 48.44% <ø> (ø)
networking 77.48% <ø> (+0.01%) ⬆️
rpc 58.80% <ø> (ø)
consensus 63.53% <ø> (ø)
revm 31.97% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.32% <0.00%> (-0.04%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 2801e68 Aug 24, 2023
@mattsse mattsse deleted the matt/move-validate-toeip4844 branch August 24, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement New feature or request M-eip This change relates to the implementation of an EIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants