Skip to content

feat: add eth extension trait for EthValidator#4343

Merged
mattsse merged 1 commit intomainfrom
matt/add-extension-trait
Aug 24, 2023
Merged

feat: add eth extension trait for EthValidator#4343
mattsse merged 1 commit intomainfrom
matt/add-extension-trait

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 24, 2023

adds an extension trait for extracting blobs used by the ethvalidator

@mattsse mattsse requested a review from Rjected as a code owner August 24, 2023 13:02
@mattsse mattsse added M-changelog This change should be included in the changelog A-tx-pool Related to the transaction mempool labels Aug 24, 2023
@mattsse mattsse force-pushed the matt/add-extension-trait branch from 63b1113 to 941e172 Compare August 24, 2023 13:04
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #4343 (941e172) into main (b473f20) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc/src/eth/error.rs 9.94% <0.00%> (-0.06%) ⬇️
crates/transaction-pool/src/error.rs 0.00% <0.00%> (ø)
crates/transaction-pool/src/lib.rs 38.62% <ø> (ø)
crates/transaction-pool/src/traits.rs 8.87% <0.00%> (-0.22%) ⬇️
crates/transaction-pool/src/validate/eth.rs 0.00% <0.00%> (ø)
crates/transaction-pool/src/validate/mod.rs 55.88% <0.00%> (-2.29%) ⬇️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <0.00%> (-0.02%) ⬇️
unit-tests 63.82% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.03% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.71% <ø> (ø)
trie 94.88% <ø> (+0.03%) ⬆️
txpool 47.62% <0.00%> (-0.83%) ⬇️
networking 77.49% <ø> (+0.01%) ⬆️
rpc 58.80% <0.00%> (+<0.01%) ⬆️
consensus 63.53% <ø> (ø)
revm 31.97% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.33% <ø> (-0.04%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +225 to +231
} else {
return TransactionValidationOutcome::Invalid(
transaction,
InvalidPoolTransactionError::MissingEip4844Blob,
)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit f0346c6 Aug 24, 2023
@mattsse mattsse deleted the matt/add-extension-trait branch August 24, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tx-pool Related to the transaction mempool M-changelog This change should be included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants