Skip to content

feat: remove finalized blobs#4342

Merged
mattsse merged 1 commit intomainfrom
matt/remove-finalized-blobs
Aug 24, 2023
Merged

feat: remove finalized blobs#4342
mattsse merged 1 commit intomainfrom
matt/remove-finalized-blobs

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 24, 2023

adds missing check to maintain loop.

if the finalized block changed, remove all finalized blobs from storage

@mattsse mattsse added A-tx-pool Related to the transaction mempool M-eip This change relates to the implementation of an EIP labels Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #4342 (a50d08f) into main (b473f20) will decrease coverage by 0.06%.
The diff coverage is 6.45%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/blobstore/mod.rs 0.00% <ø> (ø)
crates/transaction-pool/src/maintain.rs 2.92% <0.00%> (-0.26%) ⬇️
crates/transaction-pool/src/blobstore/tracker.rs 70.37% <50.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <0.00%> (-0.02%) ⬇️
unit-tests 63.82% <6.45%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.03% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.71% <ø> (ø)
trie 94.88% <ø> (+0.03%) ⬆️
txpool 47.66% <6.45%> (-0.79%) ⬇️
networking 77.46% <ø> (-0.01%) ⬇️
rpc 58.80% <ø> (ø)
consensus 63.53% <ø> (ø)
revm 31.97% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.33% <ø> (-0.04%) ⬇️

@mattsse mattsse requested a review from Rjected August 24, 2023 13:01
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 0beaf85 Aug 24, 2023
@mattsse mattsse deleted the matt/remove-finalized-blobs branch August 24, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tx-pool Related to the transaction mempool M-eip This change relates to the implementation of an EIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants