Skip to content

feat(book): basic pruning chapter#4334

Merged
gakonst merged 3 commits intomainfrom
alexey/book-pruning
Aug 23, 2023
Merged

feat(book): basic pruning chapter#4334
gakonst merged 3 commits intomainfrom
alexey/book-pruning

Conversation

@shekhirin
Copy link
Member

As per the PR title.

@shekhirin shekhirin added C-docs An addition or correction to our documentation A-pruning Related to pruning or full node labels Aug 23, 2023
@shekhirin shekhirin requested a review from joshieDo August 23, 2023 20:02
@shekhirin shekhirin marked this pull request as ready for review August 23, 2023 20:08
@shekhirin shekhirin requested a review from gakonst as a code owner August 23, 2023 20:08
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4334 (48a5b05) into main (1eee5ee) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.75% <ø> (-0.02%) ⬇️
unit-tests 63.88% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.11% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.71% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 48.44% <ø> (ø)
networking 77.48% <ø> (-0.25%) ⬇️
rpc 58.79% <ø> (-0.02%) ⬇️
consensus 63.53% <ø> (ø)
revm 31.97% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.34% <ø> (-0.05%) ⬇️

Comment on lines +59 to +60
> TODO: `prune parts / RPC methods` table that shows which RPCs becomes unavailable when certain parts of the data
> are pruned No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we can do in follow-up, but for sure before alpha.8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should basically recommend some use-case driven example configs, for very very aggressive pruners e.g.

Comment on lines +9 to +10
Reth also supports pruning of historical data and running as a full node. This chapter will walk through
the steps for running Reth as a full node, what caveats to expect and how to configure your own pruned node.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add how big the node is with various configs in followup

@gakonst gakonst added this pull request to the merge queue Aug 23, 2023
@gakonst gakonst removed this pull request from the merge queue due to a manual request Aug 23, 2023
@gakonst gakonst merged commit fca6404 into main Aug 23, 2023
@gakonst gakonst deleted the alexey/book-pruning branch August 23, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pruning Related to pruning or full node C-docs An addition or correction to our documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants