Skip to content

feat(bin): unhide and enable full flag#4327

Merged
gakonst merged 3 commits intomainfrom
alexey/enable-node-full-flag
Aug 23, 2023
Merged

feat(bin): unhide and enable full flag#4327
gakonst merged 3 commits intomainfrom
alexey/enable-node-full-flag

Conversation

@shekhirin
Copy link
Member

@shekhirin shekhirin commented Aug 23, 2023

Blocked by #4246, #4318

Unhides and removes the bail from --full CLI flag. Also adjusts the book.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4327 (7a483b5) into main (1eee5ee) will decrease coverage by 0.11%.
The diff coverage is 25.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/pruning_args.rs 7.14% <25.00%> (-12.86%) ⬇️

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.76% <0.00%> (-0.01%) ⬇️
unit-tests 63.84% <25.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.03% <25.00%> (-0.09%) ⬇️
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.71% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.94% <ø> (-0.51%) ⬇️
networking 77.46% <ø> (-0.27%) ⬇️
rpc 58.79% <ø> (-0.02%) ⬇️
consensus 63.45% <ø> (-0.09%) ⬇️
revm 31.97% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.36% <ø> (-0.03%) ⬇️

@shekhirin shekhirin requested review from joshieDo and mattsse August 23, 2023 19:10
@shekhirin shekhirin marked this pull request as ready for review August 23, 2023 19:10
@shekhirin shekhirin added A-cli Related to the reth CLI A-pruning Related to pruning or full node labels Aug 23, 2023
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very exciting

@gakonst gakonst added this pull request to the merge queue Aug 23, 2023
@gakonst gakonst removed this pull request from the merge queue due to a manual request Aug 23, 2023
@gakonst gakonst merged commit bfa130d into main Aug 23, 2023
@gakonst gakonst deleted the alexey/enable-node-full-flag branch August 23, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Related to the reth CLI A-pruning Related to pruning or full node

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants