Skip to content

feat: add shouldOverrideBuilder to ExecutionPayloadEnvelope#4322

Merged
Rjected merged 2 commits intomainfrom
dan/add-should-override-builder-flag
Aug 22, 2023
Merged

feat: add shouldOverrideBuilder to ExecutionPayloadEnvelope#4322
Rjected merged 2 commits intomainfrom
dan/add-should-override-builder-flag

Conversation

@Rjected
Copy link
Member

@Rjected Rjected commented Aug 22, 2023

Adds the shouldOverrideBuilder flag from the cancun spec:

Request

  • method: engine_getPayloadV3
  • params:
    1. payloadId: DATA, 8 Bytes - Identifier of the payload build process
  • timeout: 1s

Response

  • result: object
    • executionPayload: ExecutionPayloadV3
    • blockValue : QUANTITY, 256 Bits - The expected value to be received by the feeRecipient in wei
    • blobsBundle: BlobsBundleV1 - Bundle with data corresponding to blob transactions included into executionPayload
    • shouldOverrideBuilder : BOOLEAN - Suggestion from the execution layer to use this executionPayload instead of an externally provided one
  • error: code and message set in case an exception happens while getting the payload.

@Rjected Rjected added A-rpc Related to the RPC implementation A-consensus Related to the consensus engine M-eip This change relates to the implementation of an EIP E-cancun Related to the Cancun network upgrade labels Aug 22, 2023
@Rjected Rjected requested a review from mattsse as a code owner August 22, 2023 20:14
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #4322 (6d5b98e) into main (1859321) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/payload/builder/src/payload.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-types/src/eth/engine/payload.rs 85.29% <ø> (ø)

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.78% <0.00%> (-0.03%) ⬇️
unit-tests 63.70% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.11% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (ø)
txpool 47.79% <ø> (-0.03%) ⬇️
networking 77.42% <ø> (-0.08%) ⬇️
rpc 58.78% <ø> (-0.02%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.78% <0.00%> (-0.04%) ⬇️
primitives 86.08% <ø> (-0.01%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rjected Rjected added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit bfc4abf Aug 22, 2023
@Rjected Rjected deleted the dan/add-should-override-builder-flag branch August 22, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-consensus Related to the consensus engine A-rpc Related to the RPC implementation E-cancun Related to the Cancun network upgrade M-eip This change relates to the implementation of an EIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants