Skip to content

chore: kebab case --dev fields #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 1 commit into from
Aug 22, 2023
Merged

chore: kebab case --dev fields #4314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions bin/reth/src/args/dev_args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pub struct DevArgs {

/// How many transactions to mine per block.
#[arg(
long = "dev.block_max_transactions",
long = "dev.block-max-transactions",
help_heading = "Dev testnet",
conflicts_with = "block_time"
)]
Expand All @@ -31,7 +31,7 @@ pub struct DevArgs {
/// Parses strings using [humantime::parse_duration]
/// --dev.block_time 12s
#[arg(
long = "dev.block_time",
long = "dev.block-time",
help_heading = "Dev testnet",
conflicts_with = "block_max_transactions",
value_parser = parse_duration,
Expand Down Expand Up @@ -66,14 +66,14 @@ mod tests {
let args = CommandParser::<DevArgs>::parse_from([
"reth",
"--dev",
"--dev.block_max_transactions",
"--dev.block-max-transactions",
"2",
])
.args;
assert_eq!(args, DevArgs { dev: true, block_max_transactions: Some(2), block_time: None });

let args =
CommandParser::<DevArgs>::parse_from(["reth", "--dev", "--dev.block_time", "1s"]).args;
CommandParser::<DevArgs>::parse_from(["reth", "--dev", "--dev.block-time", "1s"]).args;
assert_eq!(
args,
DevArgs {
Expand All @@ -89,9 +89,9 @@ mod tests {
let args = CommandParser::<DevArgs>::try_parse_from([
"reth",
"--dev",
"--dev.block_max_transactions",
"--dev.block-max-transactions",
"2",
"--dev.block_time",
"--dev.block-time",
"1s",
]);
assert!(args.is_err());
Expand Down