Skip to content

feat(bin): show db path when confirming the drop#4309

Merged
shekhirin merged 1 commit intomainfrom
alexey/db-drop-path
Aug 22, 2023
Merged

feat(bin): show db path when confirming the drop#4309
shekhirin merged 1 commit intomainfrom
alexey/db-drop-path

Conversation

@shekhirin
Copy link
Member

@shekhirin shekhirin commented Aug 22, 2023

Just to be sure what database you're deleting:

reth (main) cargo run --quiet -- db drop                                                                                                                                                                       ✭
Are you sure you want to drop the database at "/Users/shekhirin/Library/Application Support/reth/mainnet/db"? This cannot be undone. (y/N):

@shekhirin shekhirin requested a review from onbjerg as a code owner August 22, 2023 09:39
@shekhirin shekhirin requested review from mattsse and rkrasiuk August 22, 2023 09:39
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #4309 (b0357d2) into main (34b68de) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/db/mod.rs 6.40% <0.00%> (ø)

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.83% <0.00%> (+<0.01%) ⬆️
unit-tests 63.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <0.00%> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (+0.03%) ⬆️
txpool 48.20% <ø> (-0.03%) ⬇️
networking 77.47% <ø> (-0.08%) ⬇️
rpc 58.81% <ø> (ø)
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 86.14% <ø> (-0.01%) ⬇️

@rkrasiuk rkrasiuk added the A-cli Related to the reth CLI label Aug 22, 2023
@shekhirin shekhirin added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit b296c6b Aug 22, 2023
@shekhirin shekhirin deleted the alexey/db-drop-path branch August 22, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Related to the reth CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants