Skip to content

docs: add --dev flag to book#4307

Merged
mattsse merged 4 commits intoparadigmxyz:mainfrom
Sabnock01:sabnock/issue-3903
Aug 22, 2023
Merged

docs: add --dev flag to book#4307
mattsse merged 4 commits intoparadigmxyz:mainfrom
Sabnock01:sabnock/issue-3903

Conversation

@Sabnock01
Copy link
Contributor

Adds the --dev flag for reth node to the book. Resolves #3903

@Sabnock01 Sabnock01 requested a review from gakonst as a code owner August 22, 2023 03:54
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #4307 (5c8bec3) into main (07a1af8) will decrease coverage by 0.03%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.83% <ø> (-0.01%) ⬇️
unit-tests 63.75% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (ø)
txpool 48.20% <ø> (ø)
networking 77.46% <ø> (-0.03%) ⬇️
rpc 58.80% <ø> (-0.09%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 86.14% <ø> (-0.03%) ⬇️

Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! unrelated: @mattsse any reason these are in snake_case (consistency snob here)? any objections to renaming to kebab-case?

@rkrasiuk rkrasiuk added C-docs An addition or correction to our documentation A-cli Related to the reth CLI labels Aug 22, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref #4314

@mattsse mattsse enabled auto-merge August 22, 2023 14:07
@mattsse mattsse added this pull request to the merge queue Aug 22, 2023
Merged via the queue into paradigmxyz:main with commit 35c01fe Aug 22, 2023
@Sabnock01 Sabnock01 deleted the sabnock/issue-3903 branch August 22, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Related to the reth CLI C-docs An addition or correction to our documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document --dev arguments and usage in book

3 participants