fix: add docs and serde attrs to ExecutionPayload v3 fields#4302
Merged
fix: add docs and serde attrs to ExecutionPayload v3 fields#4302
Conversation
Rjected
added
C-docs
Codecov Report
... and 18 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Aug 21, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm, validation is separate
Collaborator
|
failing existing test, that needs to be updated, perhaps also a good idea to serialize if None? |
Member
Author
hmm, I'm inclined to change the test instead and keep the current serde flags, since we already have a convention of not serializing fields from later forks (for example withdrawals) |
Rjected
force-pushed
the
dan/skip-none-blob-gas
branch
from
b7ac438 to
24d2e75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
#[serde(default, skip_serializing_if = "Option::is_none")]to theExecutionPayloadV3 fields, similar to thewithdrawalsfield