Skip to content

fix: state overrides and call many args#4298

Merged
gakonst merged 1 commit intomainfrom
matt/fix-call-many-and-overrides
Aug 21, 2023
Merged

fix: state overrides and call many args#4298
gakonst merged 1 commit intomainfrom
matt/fix-call-many-and-overrides

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 21, 2023

Closes #4295

fix 1: use GethDebugTracingCallOptions as args which includes the overrides, same as traceCall
fix 2: values in stateoverrides are U256

@mattsse mattsse requested a review from Rjected as a code owner August 21, 2023 15:49
@mattsse mattsse force-pushed the matt/fix-call-many-and-overrides branch from ed62d17 to 51fc499 Compare August 21, 2023 15:49
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Aug 21, 2023
@mattsse mattsse requested a review from rkrasiuk August 21, 2023 15:49
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #4298 (51fc499) into main (3b404ac) will increase coverage by 0.00%.
The diff coverage is 70.37%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-api/src/debug.rs 100.00% <ø> (ø)
crates/rpc/rpc/src/debug.rs 9.00% <0.00%> (+0.03%) ⬆️
crates/rpc/rpc/src/eth/revm_utils.rs 37.16% <0.00%> (+0.64%) ⬆️
crates/rpc/rpc-types/src/eth/state.rs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.83% <0.00%> (-0.01%) ⬇️
unit-tests 63.75% <70.37%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (ø)
txpool 48.22% <ø> (ø)
networking 77.48% <ø> (-0.05%) ⬇️
rpc 58.80% <70.37%> (+0.08%) ⬆️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 86.16% <ø> (-0.01%) ⬇️

@gakonst gakonst added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit c4626f7 Aug 21, 2023
@gakonst gakonst deleted the matt/fix-call-many-and-overrides branch August 21, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stateOverrides of debug_traceCallMany does not work

2 participants