Skip to content

fix: use gas_used from execution result#4293

Merged
mattsse merged 1 commit intomainfrom
matt/use-gas-used-of-result
Aug 21, 2023
Merged

fix: use gas_used from execution result#4293
mattsse merged 1 commit intomainfrom
matt/use-gas-used-of-result

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 21, 2023

within revm the final gas_used is determined outside the inspector so we currently cannot derive it during tracing (init cost for example)

this uses the output of the inspect for gas_used

ref #4262

@mattsse mattsse requested a review from Rjected as a code owner August 21, 2023 13:08
@mattsse mattsse requested a review from onbjerg August 21, 2023 13:08
@mattsse mattsse added C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #4293 (41ca2f7) into main (eaca2a4) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
...s/revm/revm-inspectors/src/tracing/builder/geth.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/debug.rs 8.97% <0.00%> (-0.05%) ⬇️

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.84% <0.00%> (-0.03%) ⬇️
unit-tests 63.68% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (ø)
txpool 48.16% <ø> (-0.54%) ⬇️
networking 77.44% <ø> (-0.14%) ⬇️
rpc 58.72% <0.00%> (+<0.01%) ⬆️
consensus 63.53% <ø> (ø)
revm 32.03% <0.00%> (-0.01%) ⬇️
payload builder 6.82% <ø> (ø)
primitives 85.85% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit f5a3042 Aug 21, 2023
@mattsse mattsse deleted the matt/use-gas-used-of-result branch August 21, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants