Skip to content

dep: move metrics to workspace#4289

Merged
rkrasiuk merged 1 commit intomainfrom
rkrasiuk/dep-metrics-workspace
Aug 21, 2023
Merged

dep: move metrics to workspace#4289
rkrasiuk merged 1 commit intomainfrom
rkrasiuk/dep-metrics-workspace

Conversation

@rkrasiuk
Copy link
Contributor

Description

Move metrics to workspace.

@rkrasiuk rkrasiuk added C-debt A clean up/refactor of existing code A-dependencies Pull requests or issues that are about dependencies labels Aug 21, 2023
Copy link
Member

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks!

@rkrasiuk rkrasiuk enabled auto-merge August 21, 2023 09:27
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #4289 (849ce50) into main (5c88193) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

see 4 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.87% <ø> (-0.01%) ⬇️
unit-tests 63.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.81% <ø> (-0.04%) ⬇️
txpool 48.58% <ø> (ø)
networking 77.43% <ø> (+<0.01%) ⬆️
rpc 58.70% <ø> (-0.01%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.03% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 85.94% <ø> (ø)

@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit 7f9116b Aug 21, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/dep-metrics-workspace branch August 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependencies Pull requests or issues that are about dependencies C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants