Skip to content

feat: add blob store canon tracker#4278

Merged
mattsse merged 3 commits intomainfrom
matt/add-blobstore-tracker
Aug 21, 2023
Merged

feat: add blob store canon tracker#4278
mattsse merged 3 commits intomainfrom
matt/add-blobstore-tracker

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 19, 2023

adds a tracker type that keeps track of mined blob transactions so they can be removed once finalized.

this is missing cleanup on finalized which will be implemented in a followup

@mattsse mattsse requested a review from gakonst as a code owner August 19, 2023 12:20
@mattsse mattsse requested review from Rjected and rkrasiuk August 19, 2023 12:21
@mattsse mattsse added A-tx-pool Related to the transaction mempool C-enhancement New feature or request labels Aug 19, 2023
@mattsse mattsse force-pushed the matt/add-blobstore-tracker branch from 122e9a8 to 06ef9fb Compare August 19, 2023 12:24
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #4278 (06ef9fb) into main (2abfe23) will decrease coverage by 0.09%.
The diff coverage is 33.04%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/transaction/mod.rs 77.15% <0.00%> (-1.12%) ⬇️
crates/transaction-pool/src/blobstore/mem.rs 2.10% <0.00%> (-0.25%) ⬇️
crates/transaction-pool/src/blobstore/mod.rs 0.00% <ø> (ø)
crates/transaction-pool/src/blobstore/noop.rs 0.00% <0.00%> (ø)
crates/transaction-pool/src/lib.rs 37.91% <0.00%> (-1.30%) ⬇️
crates/transaction-pool/src/maintain.rs 3.10% <0.00%> (-0.11%) ⬇️
crates/transaction-pool/src/metrics.rs 33.33% <ø> (ø)
crates/transaction-pool/src/pool/mod.rs 44.13% <0.00%> (-1.80%) ⬇️
crates/transaction-pool/src/traits.rs 8.19% <ø> (ø)
crates/transaction-pool/src/blobstore/tracker.rs 70.37% <70.37%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.84% <0.00%> (-0.04%) ⬇️
unit-tests 63.70% <33.04%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.12% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (+0.03%) ⬆️
txpool 48.37% <36.89%> (-0.74%) ⬇️
networking 77.46% <ø> (-0.05%) ⬇️
rpc 58.70% <ø> (-0.02%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.03% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 85.85% <0.00%> (-0.10%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit 566e244 Aug 21, 2023
@mattsse mattsse deleted the matt/add-blobstore-tracker branch August 21, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tx-pool Related to the transaction mempool C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants