Skip to content

feat: provide a way to opt out of pool updates#4270

Merged
mattsse merged 1 commit intomainfrom
matt/add-opt-out-of-updates
Aug 21, 2023
Merged

feat: provide a way to opt out of pool updates#4270
mattsse merged 1 commit intomainfrom
matt/add-opt-out-of-updates

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 18, 2023

provide a way to disable live pool updates

@mattsse mattsse requested a review from rkrasiuk August 18, 2023 15:49
@mattsse mattsse added M-changelog This change should be included in the changelog A-tx-pool Related to the transaction mempool labels Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #4270 (2eab029) into main (849a47e) will increase coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 22.22%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/traits.rs 9.03% <0.00%> (-0.06%) ⬇️
crates/transaction-pool/src/pool/best.rs 75.96% <14.28%> (-4.66%) ⬇️
crates/transaction-pool/src/pool/pending.rs 84.27% <100.00%> (ø)

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.84% <22.22%> (-0.07%) ⬇️
unit-tests 63.85% <22.22%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.13% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (+0.05%) ⬆️
trie 94.85% <ø> (+0.13%) ⬆️
txpool 49.51% <22.22%> (-0.11%) ⬇️
networking 77.50% <ø> (+0.03%) ⬆️
rpc 58.64% <ø> (-0.07%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.03% <ø> (-0.12%) ⬇️
payload builder 6.82% <ø> (ø)
primitives 86.36% <ø> (+0.04%) ⬆️

@mattsse mattsse added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit eaca2a4 Aug 21, 2023
@mattsse mattsse deleted the matt/add-opt-out-of-updates branch August 21, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tx-pool Related to the transaction mempool M-changelog This change should be included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants